feat(hive): vendor Hive 3.1 metastore + fb303 Thrift IDL#694
Merged
Conversation
wgtmac
reviewed
Jun 4, 2026
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
Thanks for importing Hive related files. I've left some minor comments. BTW, the title is not core. Perhaps rename to feat(hive): vendor Hive 3.1 metastore + fb303 Thrift IDL
gty404
reviewed
Jun 6, 2026
MisterRaindrop
force-pushed
the
chore/hive-vendor-idl
branch
from
291b25f to
3d67f5d
Compare
MisterRaindrop
changed the title
Vendor the Apache Hive standalone-metastore IDL and the fb303 helper
IDL it includes into thirdparty/hive_metastore/. These files are the
input for the C++ HMS client bindings, generated by a follow-up commit
that invokes `thrift --gen cpp` at build time.
Provenance is pinned to immutable upstream tags and commit SHAs so it
is reproducible and future updates are deterministic:
* hive_metastore.thrift - apache/hive rel/release-3.1.3
@ 04c1b307d1bbd1ae268ad47dc36ca4f50c6d9cd8
* share/fb303/if/fb303.thrift - apache/thrift v0.14.0
@ 8411e189b0af09e5baad34031555870cf692c1ad
Both upstream files retain their original Apache 2.0 license headers;
only trailing whitespace and final newlines were normalized by the
repository's pre-commit hooks. thirdparty/hive_metastore/README.md
records the pinned sources. The vendored tree consists of other ASF
projects' files, so no NOTICE entry is required (ASF projects are
exempt); .github/.licenserc.yaml adds thirdparty/** to paths-ignore so
the license-eye check skips it.
Part of the iceberg-cpp HiveCatalog port that follows iceberg-rust's
iceberg-catalog-hms crate as a blueprint.
MisterRaindrop
force-pushed
the
chore/hive-vendor-idl
branch
from
3d67f5d to
d9fc3f8
Compare
wgtmac
approved these changes
Jun 9, 2026
Member
|
Thank you, @MisterRaindrop and @gty404! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendor the Apache Hive 3.1 standalone-metastore IDL and the fb303 helper IDL it includes into third_party/hive_metastore/. These files are the input for the C++ HMS client bindings, generated by a follow-up commit that invokes
thrift --gen cppat build time.Provenance:
Both upstream files retain their Apache 2.0 license headers; only trailing whitespace and final newlines were normalized by the repository's pre-commit hooks. third_party/hive_metastore/NOTICE records the upstream sources, and the project root NOTICE references it. .github/.licenserc.yaml gains third_party/** to paths-ignore so the license-eye check skips the vendored tree.